Fix loading legacy projects

[vzarytovskii]

Fix for a bug with loading legacy projects, which I have introduced in 17.7, moving to tasks.
We might want to go through backporting

[0101]

Here's a VSIX built with this change in case anyone wants to use it in VS prior to insertion:

Link to OneDrive

[ghostinside]

the issue is back again, vsix does not help, мы net community 17.9.2

[vzarytovskii]

the issue is back again, vsix does not help, мы net community 17.9.2

I can load it just fine, not sure what's wrong. Any examples of projects?

[ghostinside]

[vzarytovskii]

Screenshot is not of particular help. I can't reproduce it with neither old nor new project.

[ghostinside]

what info needs to provide, project guid, etc?

[ghostinside]

f#

{50b30417-ae00-46c5-9fd1-f5094510cf4d}

c#

{3A499F41-1A5A-46A1-BF01-8ECADB9C4223}

f# project refs

<ItemGroup>
    <Reference Include="ApplicationSettings">
      <HintPath>..\lib\ApplicationSettings\v2.0\ApplicationSettings.dll</HintPath>
    </Reference>
    <Reference Include="FSharp.Core">
      <HintPath>..\packages\FSharp.Core.8.0.200\lib\netstandard2.0\FSharp.Core.dll</HintPath>
    </Reference>
    <Reference Include="mscorlib" />
    <Reference Include="System.Core" />
  </ItemGroup>
  <ItemGroup>
    <ProjectReference Include="..\Core\Core.csproj">
      <Name>Core</Name>
      <Project>{3a499f41-1a5a-46a1-bf01-8ecadb9c4223}</Project>
      <Private>True</Private>
    </ProjectReference>
  </ItemGroup>

[vzarytovskii]

what info needs to provide, project guid, etc?

Full repro, or how to create it.

[ghostinside]

reproducible solution https://drive.google.com/drive/folders/1RhiIJ_GRXDQKy5XWLp95GkR2H9F7tuYj?usp=sharing

…

On Tue, Mar 12, 2024 at 11:03 AM Vlad Zarytovskii ***@***.***> wrote: what info needs to provide, project guid, etc? Full repro, or how to create it. — Reply to this email directly, view it on GitHub <#15796 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE> . You are receiving this because you commented.Message ID: ***@***.***>

[vzarytovskii]

reproducible solution https://drive.google.com/drive/folders/1RhiIJ_GRXDQKy5XWLp95GkR2H9F7tuYj?usp=sharing
…
On Tue, Mar 12, 2024 at 11:03 AM Vlad Zarytovskii @.> wrote: what info needs to provide, project guid, etc? Full repro, or how to create it. — Reply to this email directly, view it on GitHub <#15796 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE . You are receiving this because you commented.Message ID: @.>

I can't see any issues, colouring, tooltips, autocomplete and type hints seem to work fine:

Not sure what's wrong, maybe VS installation is broken.

[ghostinside]

on my end [image: image.png] extensions [image: image.png] [image: image.png] what can i check, any thoughts? On Tue, Mar 12, 2024 at 11:53 AM Vlad Zarytovskii ***@***.***> wrote:

…

reproducible solution https://drive.google.com/drive/folders/1RhiIJ_GRXDQKy5XWLp95GkR2H9F7tuYj?usp=sharing … <#m_-5229628934080720958_> On Tue, Mar 12, 2024 at 11:03 AM Vlad Zarytovskii *@*.*> wrote: what info needs to provide, project guid, etc? Full repro, or how to create it. — Reply to this email directly, view it on GitHub <#15796 (comment) <#15796 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE <https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE> . You are receiving this because you commented.Message ID: @.*> I can't see any issues, colouring, tooltips and autocomplete seem to work fine: image.png (view on web) <https://github.com/dotnet/fsharp/assets/1260985/83b9e50a-2698-4340-ba36-056b5ef6b9a3> image.png (view on web) <https://github.com/dotnet/fsharp/assets/1260985/0653cb5e-4923-4c5f-ad69-860bfff791fc> Not sure what's wrong, maybe VS installation is broken. — Reply to this email directly, view it on GitHub <#15796 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQPEUJ6MVRJEUOZBKDTZLDYX4QJHAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHE4DSOBTGU> . You are receiving this because you commented.Message ID: ***@***.***>

[vzarytovskii]

on my end [image: image.png] extensions [image: image.png] [image: image.png] what can i check, any thoughts? On Tue, Mar 12, 2024 at 11:53 AM Vlad Zarytovskii @.> wrote:
…
reproducible solution https://drive.google.com/drive/folders/1RhiIJ_GRXDQKy5XWLp95GkR2H9F7tuYj?usp=sharing … <#m_-5229628934080720958_> On Tue, Mar 12, 2024 at 11:03 AM Vlad Zarytovskii @.> wrote: what info needs to provide, project guid, etc? Full repro, or how to create it. — Reply to this email directly, view it on GitHub <#15796 (comment) <#15796 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE . You are receiving this because you commented.Message ID: @.> I can't see any issues, colouring, tooltips and autocomplete seem to work fine: image.png (view on web) https://github.com/dotnet/fsharp/assets/1260985/83b9e50a-2698-4340-ba36-056b5ef6b9a3 image.png (view on web) https://github.com/dotnet/fsharp/assets/1260985/0653cb5e-4923-4c5f-ad69-860bfff791fc Not sure what's wrong, maybe VS installation is broken. — Reply to this email directly, view it on GitHub <#15796 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQPEUJ6MVRJEUOZBKDTZLDYX4QJHAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHE4DSOBTGU . You are receiving this because you commented.Message ID: @.**>

I don't see any images. You can try repairing VS installation via installer (not deleting and reinstalling), trying other VS version (VS 17.10 preview perhaps)? Also, what are F# settings under "Editor -> F#"?

[ghostinside]

removed extension F# tools, sample solution started working On Tue, Mar 12, 2024 at 12:02 PM Aleksandr Kovalev < ***@***.***> wrote:

…

on my end [image: image.png] extensions [image: image.png] [image: image.png] what can i check, any thoughts? On Tue, Mar 12, 2024 at 11:53 AM Vlad Zarytovskii < ***@***.***> wrote: > reproducible solution > https://drive.google.com/drive/folders/1RhiIJ_GRXDQKy5XWLp95GkR2H9F7tuYj?usp=sharing > … <#m_-2765763775626559909_m_-5229628934080720958_> > On Tue, Mar 12, 2024 at 11:03 AM Vlad Zarytovskii *@*.*> wrote: what > info needs to provide, project guid, etc? Full repro, or how to create it. > — Reply to this email directly, view it on GitHub <#15796 (comment) > <#15796 (comment)>>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE > <https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE> > . You are receiving this because you commented.Message ID: @.*> > > I can't see any issues, colouring, tooltips and autocomplete seem to work > fine: > image.png (view on web) > <https://github.com/dotnet/fsharp/assets/1260985/83b9e50a-2698-4340-ba36-056b5ef6b9a3> > image.png (view on web) > <https://github.com/dotnet/fsharp/assets/1260985/0653cb5e-4923-4c5f-ad69-860bfff791fc> > > Not sure what's wrong, maybe VS installation is broken. > > — > Reply to this email directly, view it on GitHub > <#15796 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACQPEUJ6MVRJEUOZBKDTZLDYX4QJHAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHE4DSOBTGU> > . > You are receiving this because you commented.Message ID: > ***@***.***> >

[vzarytovskii]

removed extension F# tools, sample solution started working On Tue, Mar 12, 2024 at 12:02 PM Aleksandr Kovalev < @.> wrote:
…
on my end [image: image.png] extensions [image: image.png] [image: image.png] what can i check, any thoughts? On Tue, Mar 12, 2024 at 11:53 AM Vlad Zarytovskii < @.> wrote: > reproducible solution > https://drive.google.com/drive/folders/1RhiIJ_GRXDQKy5XWLp95GkR2H9F7tuYj?usp=sharing > … <#m_-2765763775626559909_m_-5229628934080720958_> > On Tue, Mar 12, 2024 at 11:03 AM Vlad Zarytovskii @.> wrote: what > info needs to provide, project guid, etc? Full repro, or how to create it. > — Reply to this email directly, view it on GitHub <#15796 (comment) > <#15796 (comment)>>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE > https://github.com/notifications/unsubscribe-auth/ACQPEUMTH6KRIV4CXBWSVDDYX4KLRAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHA3DGMZUHE > . You are receiving this because you commented.Message ID: @.> > > I can't see any issues, colouring, tooltips and autocomplete seem to work > fine: > image.png (view on web) > https://github.com/dotnet/fsharp/assets/1260985/83b9e50a-2698-4340-ba36-056b5ef6b9a3 > image.png (view on web) > https://github.com/dotnet/fsharp/assets/1260985/0653cb5e-4923-4c5f-ad69-860bfff791fc > > Not sure what's wrong, maybe VS installation is broken. > > — > Reply to this email directly, view it on GitHub > <#15796 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ACQPEUJ6MVRJEUOZBKDTZLDYX4QJHAVCNFSM6AAAAAA3PX4YVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHE4DSOBTGU > . > You are receiving this because you commented.Message ID: > @.***> >

Any VSIX published in the issues will likely not work in the newer VS versions

[ghostinside]

all good, mail solution also started working, thx for help