Skip to content

Add CI leg to test strict indentation #15643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2023
Merged

Add CI leg to test strict indentation #15643

merged 5 commits into from
Jul 25, 2023

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Jul 20, 2023

Adds a new CI leg to test the indentation/parser changes independently from other preview changes, as suggested in #15637 (comment).

@auduchinok auduchinok requested a review from a team as a code owner July 20, 2023 11:54
@auduchinok auduchinok force-pushed the ci-indentation-strict branch from 5f93d2f to 313102b Compare July 20, 2023 11:59
@auduchinok
Copy link
Member Author

auduchinok commented Jul 20, 2023

@vzarytovskii Could you check what's wrong with the new leg when you have time, please?
There's an error about publishing build artifacts, and I don't know what to do with it.

@vzarytovskii
Copy link
Member

vzarytovskii commented Jul 20, 2023

@vzarytovskii Could you check what's wrong with the new leg when you have time, please? There's an error about publishing build artifacts, and I don't know what to do with it.

I'm actually not sure custom flag is passed there, I think build script might be treating it as its own flag, and not passed to msbuild?

@vzarytovskii
Copy link
Member

vzarytovskii commented Jul 20, 2023

@auduchinok yeah, build script failed and there were no logs to upload:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=346335&view=logs&j=70e6e619-3cf7-5833-fa8f-6499093f7398&t=20ac6483-4e71-5107-5aa7-585726d1ae96

A bit misleading message though.

T-Gro
T-Gro reviewed Jul 24, 2023
View reviewed changes
@auduchinok @T-Gro
Update azure-pipelines.yml
7790e9c 
Co-authored-by: Tomas Grosup <[email protected]>
@auduchinok
Copy link
Member Author

auduchinok commented Jul 24, 2023

This is ready.

Thanks for the help! 🙂

@vzarytovskii vzarytovskii enabled auto-merge (squash) July 25, 2023 10:01
abonie
abonie reviewed Jul 25, 2023
View reviewed changes
@vzarytovskii vzarytovskii merged commit 0705aa1 into dotnet:main Jul 25, 2023
@auduchinok auduchinok deleted the ci-indentation-strict branch July 25, 2023 10:27
@allisonchou allisonchou mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro left review comments

@abonie abonie abonie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@auduchinok @vzarytovskii @abonie @T-Gro