Fix: 14814 --- Inaccurate error in anonymous record copy-and-update #15625
Conversation
|
@auduchinok fyi |
|
This ended up in 17.7 and 7.0, will need a backport to 17.7 and tactics...sigh |
|
/backport to release/dev17.7 |
|
Started backporting to release/dev17.7: https://github.com/dotnet/fsharp/actions/runs/5596481474 |
| Assert.AreNotEqual(getMfv.CurriedParameterGroups, setMfv.CurriedParameterGroups) | ||
| | _ -> Assert.Fail "Expected symbols to be FSharpMemberOrFunctionOrValue" | ||
|
|
||
| [<Test>] |
There was a problem hiding this comment.
@KevinRansom why did you remove these tests?
You really removed a bunch of these that are not even related!
There was a problem hiding this comment.
Clearly not: 2ef33c4#diff-86de212e8dc5b638058239f2b2b485cd6207f61b3acb2556de8bb7fef15065ea
Tests are removed that were not introduced by #15214
There was a problem hiding this comment.
Seems mistakenly removed. It needed a quick revert, so we won't miss backport dates. I will re-add them
Thanks. I've just checked, and it doesn't seem to be connected to #15214 (more details in #14814 (comment)) |
…update (dotnet#15625)" This reverts commit 13072ec.
|
A proper fix is in #15638. |
5 participants
This error was introduced with this commit: 2ef33c4
Checked in code:
The fix is to revert the breaking commit:
Someone should revisit the original commit to see if it can be made robust to the repro in 14814