Skip to content

<WarningLevel>0 should work also for "Information" diagnostics, tests extended #15608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2023
+21 −1
Merged

<WarningLevel>0 should work also for "Information" diagnostics, tests extended #15608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d64c493
warnlevel 0 examples added
T-Gro Jul 17, 2023
66b5b18
Info level diagnostics not displayed at warn:0 setting
T-Gro Jul 17, 2023
4d9f060
Merge branch 'main' into 15375-warn0-still-shows-warnings
T-Gro Jul 17, 2023
a2575a6
Merge branch 'main' into 15375-warn0-still-shows-warnings
KevinRansom Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compiler/Driver/CompilerDiagnostics.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ type PhasedDiagnostic with
match x.Exception with
| DiagnosticEnabledWithLanguageFeature (_, _, _, enabled) -> enabled
| _ ->
(severity = FSharpDiagnosticSeverity.Info)
(severity = FSharpDiagnosticSeverity.Info && level > 0)
|| (severity = FSharpDiagnosticSeverity.Warning && level >= x.WarningLevel)

/// Indicates if a diagnostic should be reported as an informational
Expand Down
2 changes: 2 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/CompilerOptions/fsc/warn/warn.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ module TestCompilerWarningLevel =
[<Theory; Directory(__SOURCE_DIRECTORY__, Includes=[|"warn_level0.fs"|])>]
let ``warn_level0_fs --warn:0`` compilation =
compilation
|> withLangVersionPreview
|> asExe
|> withOptions ["--warn:0"]
|> compileAndRun
|> shouldSucceed
|> withDiagnostics []

[<Theory; Directory(__SOURCE_DIRECTORY__, Includes=[|"warn_level1.fs"|])>]
let ``warn_level1_fs --warn:1 --warnaserror:52`` compilation =
Expand Down
18 changes: 18 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/CompilerOptions/fsc/warn/warn_level0.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,20 @@
// #NoMT #CompilerOptions

[<NoComparison>]
/// Meh - Informational diagnostics "XML comment is not placed on a valid language element."
type A = int

let x = 10
// Normally a The result of this equality expression has type 'bool' and is implicitly discarded.
x = 20

let mul x y = x * y
// Normally a warning
[<TailCall>]
let rec fact n acc =
if n = 0
then acc
else (fact (n - 1) (mul n acc)) + 23

// Normally a 'Main module of program is empty: nothing will happen when it is run' warning
()