Fix anonymous records internal error when nested with overlapping labels #15519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
reviewed
Jun 30, 2023
tests/FSharp.Compiler.ComponentTests/EmittedIL/Misc/AnonRecd.fs.il.net472.bsl
Outdated
Show resolved
Hide resolved
T-Gro
previously requested changes
Jun 30, 2023
Member
T-Gro
left a comment
T-Gro
left a comment
There was a problem hiding this comment.
Postponing until we get a clarification/test/.. on how this affects name stability.
The RFC explicitely mentions also here:
This name must never change in future F# compilers
Add a separator in between labels' bytes to prevent later hash collision
abonie
force-pushed
the
fix-anonrecd-nested-with-label-overlap
branch
from
751ec73 to
4b4e365
Compare
New property (IlTypeName) needs to be set on creation
Member
Author
I have addressed this now. It's a bit clunky - we use new modified stamps everywhere except for generating type names, where we use the old recipe - just to make sure it does not affect backward compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix secondary issue reported here #6411
AnonRecdTypeInfowas concatenating all of the record's sorted labels to create a key for some post inference check. If for two records concatenating their labels gave the same result, then the key was also the same which resulted in some collisions.