LexFilter/strict: add compiler option #15491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
force-pushed
the
lexFilter-strictIndentation-option
branch
from
d6ce1b7 to
f8df0f2
Compare
T-Gro
reviewed
Jun 27, 2023
T-Gro
reviewed
Jun 27, 2023
vsintegration/src/FSharp.Editor/Classification/ClassificationService.fs
Outdated
Show resolved
Hide resolved
T-Gro
approved these changes
Jun 27, 2023
auduchinok
force-pushed
the
lexFilter-strictIndentation-option
branch
from
b567279 to
28b43a3
Compare
Member
Author
|
This is ready. |
Member
Author
|
Is there something else that needs to be done, apart from rebasing to |
edgarfgp
approved these changes
Jul 11, 2023
T-Gro
reviewed
Jul 11, 2023
abonie
approved these changes
Jul 11, 2023
Contributor
|
Yeah this needs a rebase but then we can probably get this in. |
auduchinok
force-pushed
the
lexFilter-strictIndentation-option
branch
from
e920484 to
9261f94
Compare
Member
Author
|
It's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a switch proposed in fsharp/fslang-suggestions#1273 (comment).
By default, this is still controlled by the language version, but this switch allows enabling/disabling the new behaviour separately when needed.
I haven't worked on public facing compiler options previously, so please let me know if I missed some step or should've done something differently.