Skip to content

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Jun 21, 2023

Adds tokenizer support for unfinished identifiers:

`
``

These identifiers have non-zero length in the lexer, but have an empty identifier string.
Fixes this issue: #15452 (comment)

@auduchinok auduchinok requested a review from a team as a code owner June 21, 2023 15:08
@auduchinok auduchinok force-pushed the vs-tokenizer-unfinishedIdent branch from cd5aa3a to 84db6d2 Compare June 21, 2023 15:43
@T-Gro
Copy link
Member

T-Gro commented Jun 22, 2023

Due to the nature and criticality of the issue this targets, can you please add an integration test here?
e.g. for completion list (using the code which @kerams used for reporting this in the first place).

@T-Gro T-Gro self-requested a review June 22, 2023 08:18
@auduchinok auduchinok force-pushed the vs-tokenizer-unfinishedIdent branch from 84db6d2 to 5cd96d1 Compare June 22, 2023 09:38
@auduchinok
Copy link
Member Author

@T-Gro Done.

@vzarytovskii vzarytovskii merged commit f9ed906 into dotnet:main Jun 22, 2023
@auduchinok auduchinok deleted the vs-tokenizer-unfinishedIdent branch June 22, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants