Checker: recover on unfinished modules and members #15458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It's ready. |
auduchinok
force-pushed
the
syntaxTree-tests-runTc
branch
from
a07f84a to
a01333d
Compare
Member
|
Could you add some integration tests to make sure VS does not blow up as described in the original issue? |
Member
Author
|
@abonie I've added such a check here: https://github.com/dotnet/fsharp/pull/15458/files#diff-e3b9dc1544df780246fc6ce79b6a1ff795afb95afd8a57b57aa99884dc35c6f2R203. It throws the same exceptions as VS would. I don't think we want to duplicate all the parser tests with VS ones, so having an assert in them seems a good way to check it. The cases initially reported in #15452 have already been covered by the parser tests (and they did fail when I added this check). |
nojaf
approved these changes
Jun 22, 2023
abonie
approved these changes
Jun 22, 2023
psfinaki
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15452.
Also adds an ignored type checking pass to the syntax tree tests to ensure that the type checker doesn't fail on the produced trees.