Skip to content

Parser: recover on unfinished namespaces and top level modules #15439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2023
Merged

Parser: recover on unfinished namespaces and top level modules #15439

merged 2 commits into from
Jun 20, 2023

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Jun 19, 2023

Add recovery for various namespaces and top level modules:

namespace

namespace Ns2
module
namespace rec
namespace

()

@auduchinok auduchinok requested a review from a team as a code owner June 19, 2023 18:56
psfinaki
psfinaki approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@psfinaki psfinaki merged commit 325d6f4 into dotnet:main Jun 20, 2023
@auduchinok auduchinok deleted the parser-namespace branch June 20, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auduchinok @psfinaki @T-Gro