Fix suggested overload from "MergeSource" to "MergeSources" #15306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current error message for when `and!` is used, but an appropriate builder overload is not defined, is incorrect. It suggests adding a `MergeSource` method but it should be called `MergeSources`.
Contributor
Author
@dotnet-policy-service agree |
Contributor
|
Looking at the DevGuide https://github.com/dotnet/fsharp/blob/main/DEVGUIDE.md#updating-fscompfs-fscompresx-and-xlf , I think you will need run one of the commands to force the FSComp to be regenerated |
Contributor
|
@njlr thanks for the nice fix. Running build should be enough to generate all the translations, then we can merge it. |
vzarytovskii
approved these changes
Jun 19, 2023
edgarfgp
approved these changes
Jun 19, 2023
Contributor
Author
|
Thanks for review. Are any more steps required on my end? |
vzarytovskii
approved these changes
Jun 19, 2023
psfinaki
approved these changes
Jun 19, 2023
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Now it's all good - thanks, merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current error message for when
and!is used, but an appropriate builder overload is not defined, is incorrect. It suggests adding aMergeSourcemethod but it should be calledMergeSources.