Add fallback range to more typars #15301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smaug123
commented
Jun 2, 2023
This was referenced Jun 2, 2023
Contributor
Author
|
I haven't done an explicit formatting; that was my editor trimming whitespace. I can undo it if you want. |
edgarfgp
approved these changes
Jun 3, 2023
nojaf
approved these changes
Jun 5, 2023
Contributor
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
I had some nitpicks on some names, this looks fine, however.
T-Gro
approved these changes
Jun 5, 2023
psfinaki
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a sneaky removal of trailing whitespace, and a reordering of a pair of args to help in pipelines.
This adds a backup range in more cases, and it turns out to be enough for #13298 .