Don't consider seq`1 prefix in NicePrint. #15280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjust expected output
Member
|
Implementing this into .IsPrefixDisplay would be better, I also do not immediately see how the flag flows into that. |
Contributor
Author
|
@T-Gro I found "a way" to set |
T-Gro
approved these changes
Jun 8, 2023
Member
It now uses the IsPrefix nicely for rest of the code, I like this change => at least the complication of finding is isolated in once place only. |
edgarfgp
approved these changes
Jun 8, 2023
psfinaki
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #15268.
I'm not quite sure this is the way to go. I was also thinking of adding an extra check for when the entity flags are created but couldn't figure it out completely when that happens.
And even if that is possible, that might be a bit of an expensive check as it probably applies to every type that is imported.