Fix pretty print error for pointer type #15207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
changed the title
abonie
force-pushed
the
print_pointer_error_fix
branch
4 times, most recently
from
c2ddc16 to
d34ebe4
Compare
abonie
commented
May 15, 2023
abonie
force-pushed
the
print_pointer_error_fix
branch
from
d34ebe4 to
2d14f3f
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
Could we maybe add some test? |
Member
Author
|
@0101 I have been looking into that today, actually not clear how to test this, but I will look some more |
Member
|
Take a look at fsharp\tests\FSharp.Compiler.ComponentTests\Scripting\Interactive.fs for inspiration - would it reproduce there? |
abonie
force-pushed
the
print_pointer_error_fix
branch
from
2d14f3f to
e12abb1
Compare
Special-case for System.Reflection.Pointer
abonie
force-pushed
the
print_pointer_error_fix
branch
from
e12abb1 to
4ed7e48
Compare
T-Gro
approved these changes
May 19, 2023
KevinRansom
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8003
If argument is of type System.Reflection.Pointer, it will be unboxed and cast to
nativeintfor pretty printing