Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Apr 28, 2023

No description provided.

@dsyme dsyme requested a review from a team as a code owner April 28, 2023 13:53
@dsyme dsyme changed the title WIP: some diff minimization for RFC FS-1060 Some diff minimization for RFC FS-1060 Apr 28, 2023
@dsyme
Copy link
Contributor Author

dsyme commented Apr 28, 2023

Does anyone understand the error?

D:\a\_work\1\s\vsintegration\ItemTemplates\CodeFile\CodeFile.csproj : error NU1301: Failed to verify the root directory of local source 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json'. [D:\a\_work\1\s\VisualFSharp.sln]
D:\a\_work\1\s\vsintegration\ItemTemplates\AppConfig\AppConfig.csproj : error NU1301: Failed to verify the root directory of local source 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json'. [D:\a\_work\1\s\VisualFSharp.sln]
D:\a\_work\1\s\vsintegration\ItemTemplates\ResourceFile\ResourceFile.csproj : error NU1301: Failed to verify the root directory of local source 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json'. [D:\a\_work\1\s\VisualFSharp.sln]

@T-Gro
Copy link
Member

T-Gro commented Apr 28, 2023

Am I missing any major change-category apart from this list?

  • usage of MaybeNull type alias
  • usage of Null / NonNull active patterns , and 'nonNull' conversion func
  • where possible, replacing Unchecked.defaultOf with 'null'
  • cosmetics in array and list declaration style

@dsyme
Copy link
Contributor Author

dsyme commented Apr 28, 2023

Am I missing any major change-category apart from this list?

That's about it I think!

@dsyme
Copy link
Contributor Author

dsyme commented Apr 29, 2023

Another odd error, only on Mac, is this a heisenerror?

2023-04-29T00:00:15.3506910Z System.Exception: Failed: 1
2023-04-29T00:00:15.3507600Z    at <StartupCode$AssemblyVersion03>.$AssemblyVersion03.main@()
2023-04-29T00:00:15.3508330Z    at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
2023-04-29T00:00:15.3509080Z    at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
2023-04-29T00:00:15.3509820Z -------
2023-04-29T00:00:15.3604960Z [xUnit.net 00:01:14.68]     FSharp.Compiler.ComponentTests.Conformance.DeclarationElements.CustomAttributes.AttributeUsage.AssemblyVersion03_fs(compilation: AssemblyVersion03.fs) [FAIL]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants