Skip to content

Enable fast find references by default #15129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Enable fast find references by default #15129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ type internal FSharpWorkspaceServiceFactory [<System.Composition.ImportingConstr
let useSyntaxTreeCache = editorOptions.LanguageServicePerformance.UseSyntaxTreeCache

let enableFastFindReferences =
editorOptions.LanguageServicePerformance.EnableFastFindReferences
editorOptions.LanguageServicePerformance.EnableFastFindReferencesAndRename

let isInlineParameterNameHintsEnabled =
editorOptions.Advanced.IsInlineParameterNameHintsEnabled
Expand Down
6 changes: 3 additions & 3 deletions vsintegration/src/FSharp.Editor/Options/EditorOptions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ type LanguageServicePerformanceOptions =
AllowStaleCompletionResults: bool
TimeUntilStaleCompletion: int
EnableParallelReferenceResolution: bool
EnableFastFindReferences: bool
EnableFastFindReferencesAndRename: bool
EnablePartialTypeChecking: bool
UseSyntaxTreeCache: bool
}
Expand All @@ -91,7 +91,7 @@ type LanguageServicePerformanceOptions =
AllowStaleCompletionResults = true
TimeUntilStaleCompletion = 2000 // In ms, so this is 2 seconds
EnableParallelReferenceResolution = false
EnableFastFindReferences = FSharpExperimentalFeaturesEnabledAutomatically
EnableFastFindReferencesAndRename = true
EnablePartialTypeChecking = true
UseSyntaxTreeCache = FSharpExperimentalFeaturesEnabledAutomatically
}
Expand Down Expand Up @@ -237,4 +237,4 @@ module EditorOptionsExtensions =
this.EditorOptions.Advanced.IsBlockStructureEnabled

member this.IsFastFindReferencesEnabled =
this.EditorOptions.LanguageServicePerformance.EnableFastFindReferences
this.EditorOptions.LanguageServicePerformance.EnableFastFindReferencesAndRename
4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.UIResources/LanguageServicePerformanceOptionControl.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@
</GroupBox>
<GroupBox Header="{x:Static local:Strings.Find_References_Performance}">
<StackPanel>
<CheckBox x:Name="enableFastFindReferences"
IsChecked="{Binding EnableFastFindReferences}"
<CheckBox x:Name="enableFastFindReferencesAndRename"
IsChecked="{Binding EnableFastFindReferencesAndRename}"
Content="{x:Static local:Strings.Enable_Fast_Find_References}"/>
</StackPanel>
</GroupBox>
Expand Down