Skip to content

trimming tests for more core F# types #15113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2023
Merged

trimming tests for more core F# types #15113

merged 5 commits into from
Apr 19, 2023

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Apr 18, 2023 •
edited
Loading

Add more printf %A tests for a few more core F# types.

  • Option
  • Unit/Tuples
  • Array
  • List
  • Seq
  • dict/set/map
  • Lazy
  • NonStructuralComparison
  • Event<_>

The increase in size of F# core is because we are using more FSharp.Core functionality
image

@KevinRansom KevinRansom requested a review from a team as a code owner April 18, 2023 19:51
@KevinRansom KevinRansom force-pushed the printf.optionschoice branch from 7e93306 to c4ca927 Compare April 18, 2023 22:02
@KevinRansom KevinRansom changed the title printf %A for a more core F# types printf %A for more core F# types Apr 18, 2023
@KevinRansom KevinRansom changed the title printf %A for more core F# types trimming for more core F# types Apr 19, 2023
@KevinRansom KevinRansom changed the title trimming for more core F# types trimming tests for more core F# types Apr 19, 2023
T-Gro
T-Gro reviewed Apr 19, 2023
View reviewed changes
T-Gro
T-Gro reviewed Apr 19, 2023
View reviewed changes
T-Gro
T-Gro reviewed Apr 19, 2023
View reviewed changes
T-Gro
T-Gro reviewed Apr 19, 2023
View reviewed changes
T-Gro
T-Gro reviewed Apr 19, 2023
View reviewed changes
T-Gro
T-Gro reviewed Apr 19, 2023
View reviewed changes
psfinaki
psfinaki approved these changes Apr 19, 2023
View reviewed changes
@KevinRansom KevinRansom merged commit ed1c8a7 into dotnet:main Apr 19, 2023
@vzarytovskii vzarytovskii mentioned this pull request Apr 25, 2023
Closed
@KevinRansom KevinRansom deleted the printf.optionschoice branch April 29, 2023 18:45
@allisonchou allisonchou mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii left review comments

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.7

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KevinRansom @vzarytovskii @psfinaki @T-Gro