Skip to content

Parser: recover on unfinished simple 'member' declarations #15102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2023
Merged

Parser: recover on unfinished simple 'member' declarations #15102

merged 4 commits into from
Jun 15, 2023

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Apr 17, 2023 •
edited
Loading

Adds parser recovery for some cases involving unfinished members:

type T =
    member
type T =
    member this.
type T =
    member this.P =
type T =
    member this. = 1
type T =
    static

@auduchinok auduchinok requested a review from a team as a code owner April 17, 2023 14:32
@auduchinok auduchinok changed the title Parser member Parser: recover on unfinished simple 'member' declarations Apr 17, 2023
This was referenced Jun 7, 2023
Merged
Open
@auduchinok
Copy link
Member Author

auduchinok commented Jun 14, 2023 •
edited
Loading

This is ready. It's so much better with the new rules 🙂

@T-Gro T-Gro enabled auto-merge (squash) June 15, 2023 07:50
@T-Gro T-Gro merged commit 11f0f70 into dotnet:main Jun 15, 2023
@psfinaki
Copy link
Contributor

psfinaki commented Jun 15, 2023

Awesome, thanks @auduchinok :)

@auduchinok auduchinok deleted the parser-member branch June 15, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auduchinok @psfinaki @T-Gro