Skip to content

Make Anonymousrecords trimmable #15077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2023
Merged

Make Anonymousrecords trimmable #15077

merged 4 commits into from
Apr 13, 2023

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Apr 12, 2023 •
edited
Loading

  • Add Anonymous record trim smoke tests.
  • Make Printf "%A" work with trimmed Anonymous records.

@KevinRansom KevinRansom requested a review from a team as a code owner April 12, 2023 21:10
@T-Gro
Copy link
Member

T-Gro commented Apr 13, 2023

So you have updated the self contained trimming test, yet you did not have to update the length of the trimmed Fsharp.Core .dll => printing anon records only uses code which was part of the trimmed Fsharp.Core before this PR already?

@KevinRansom KevinRansom merged commit d235c0a into dotnet:main Apr 13, 2023
@allisonchou allisonchou mentioned this pull request Apr 18, 2023
Closed
@KevinRansom KevinRansom deleted the anonymousrecords branch April 29, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.7

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KevinRansom @T-Gro @psfinaki @vzarytovskii