Skip to content

Simplifying code fix telemetry a bit #15067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Simplifying code fix telemetry a bit #15067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24eef0a
Update CodeFixHelpers.fs
psfinaki Apr 11, 2023
d69fc78
Update CodeFixHelpers.fs
psfinaki Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vsintegration/src/FSharp.Editor/CodeFix/CodeFixHelpers.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ module internal CodeFixHelpers =
computeTextChanges: unit -> Async<TextChange[] option>
) =

// I don't understand how we can get anything but a single diagnostic here - as we get a single "title" here.
// But since we don't have proper testing yet, keeping it like this to verify this theory in telemetry.
// Currently there should be one Id here.
// Keeping it this way to be error- and futureproof
// as the underlying API does allow multiple Ids here.
let ids = context.Diagnostics |> Seq.map (fun d -> d.Id) |> String.concat ","

let props: (string * obj) list =
[
"name", name
"ids", ids
"title", title

// The following can help building a unique but anonymized codefix target:
// #projectid#documentid#span
Expand Down