Parser: recover on missing union case names or representations #15058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
force-pushed
the
parser-unionCase-name
branch
2 times, most recently
from
277bacf to
160d7bc
Compare
auduchinok
force-pushed
the
parser-unionCase-name
branch
2 times, most recently
from
63a6e47 to
5f3d6a1
Compare
Member
Author
|
It's ready. |
vzarytovskii
approved these changes
Apr 12, 2023
KevinRansom
previously requested changes
Apr 12, 2023
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
I quite like the parse tree mechanism to show the errors. But I would also like to see the changes visible to the user of the compiler or fsi. Does that make sense?
T-Gro
approved these changes
Apr 13, 2023
auto-merge was automatically disabled
April 13, 2023 09:28
Head branch was pushed to by a user without write access
auduchinok
force-pushed
the
parser-unionCase-name
branch
from
7dac632 to
e6c5728
Compare
auduchinok
force-pushed
the
parser-unionCase-name
branch
from
e6c5728 to
a0553a5
Compare
Member
Yeah, actually just normal fsharp diagnostics tests would be great. |
Member
Author
Yes, I've updated some of the tests in this PR. Plus, there are many new parser tests that show all the errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover on various cases of missing union case names or representations: