Parser: recover on missing expressions after rArrow #15045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
force-pushed
the
parser-rArrow-expr
branch
2 times, most recently
from
96640fd to
a44d9e9
Compare
Member
Author
|
Hm, all is green. That's unexpected! OK, I'll need to add some tests 🙂 |
auduchinok
force-pushed
the
parser-rArrow-expr
branch
from
d546d7a to
03645e7
Compare
T-Gro
approved these changes
Apr 11, 2023
vzarytovskii
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An experiment to try to recover in cases like the following:
The approach seems a bit too optimistic to me because of possible interaction with the
LexFilterrules, so I'm opening a PR just to see what can fail on CI for now.