BenchmarkDotnet config option - ignore that Test.Utilities is not optimized #15038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
approved these changes
Apr 6, 2023
0101
approved these changes
Apr 6, 2023
T-Gro
deleted the
14913-benchmarkdotnet-complains-about-non-optimized-fsharptestutilities
branch
vzarytovskii
pushed a commit
that referenced
this pull request
Apr 6, 2023
* Make trimmed printf "%A" for F# records work when trimmed (#14941) * Add tests * Embed types * baselines + fsx * Extra telemetry for codefixes (#15035) * BDN config option - ignore that Test.Utilities is not optimized (#15038) * Unignore files for formatting (.fantomasignore) if the underlying Fantomas issue has been resolved (#14960) * SI.fs fantomas'd * unignore .fsi files in Fsharp.Core * Removing commented out files from fantomasignore * Automated command ran: fantomas Co-authored-by: T-Gro <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Petr <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #14913
"Assembly FSharp.Compiler.Benchmarks which defines benchmarks references non-optimized FSharp.Test.Utilities".
Test.Utilities is used for the ProjectWorkflowBuilder, which is not what we are benchmarking - it is just sugar to describe scenarios.
We want to keep it unoptimized for easier debugging of tests, which also make use of it.