Fix send to vsfsi when using older dotnet sdks #15036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0101
reviewed
Apr 6, 2023
T-Gro
reviewed
Apr 6, 2023
T-Gro
reviewed
Apr 6, 2023
T-Gro
reviewed
Apr 6, 2023
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Petr Pokorny <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
KevinRansom
force-pushed
the
fixshowprompt
branch
from
f7b8d6f to
72104a9
Compare
T-Gro
reviewed
Apr 11, 2023
T-Gro
reviewed
Apr 11, 2023
T-Gro
reviewed
Apr 11, 2023
T-Gro
reviewed
Apr 11, 2023
T-Gro
reviewed
Apr 11, 2023
T-Gro
reviewed
Apr 11, 2023
T-Gro
requested changes
Apr 11, 2023
Member
T-Gro
left a comment
T-Gro
left a comment
There was a problem hiding this comment.
Only major comment is parsing of Single with "." without passing in explicit culture.
Either pass in the culture, OR alternatively consider using Version class (had a constructor which takes the full string, therefore avoiding the need for splitting string by dots and then concatenating back).
Plus I do not see the need for "text" in executeTextNoHistory to be lazy, can it be just a plain string?
T-Gro
approved these changes
Apr 12, 2023
abonie
reviewed
Apr 17, 2023
abonie
reviewed
Apr 17, 2023
abonie
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a global.json to pin the version of an sdk to an older one, I.e the last LTS version of the sdk, the F# script displays an obtrusive error when code is sent to fsi. This PR reverts the behaviour to it's original behaviour when using pre-7.0 sdks.
Before and after:
