An attempt to deflake some int tests #14970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
reviewed
Mar 23, 2023
vsintegration/tests/FSharp.Editor.IntegrationTests/InProcess/SolutionExplorerInProcess.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Mar 23, 2023
…olutionExplorerInProcess.cs Co-authored-by: Sam Harwell <[email protected]>
T-Gro
approved these changes
Mar 24, 2023
Contributor
|
I would expect screenshots to be attached for test failures ,and a heap dump to be collected for hangs. I didn't see either of these in the artifacts attached to the build. There may be an error in the build configuration and/or the artifact attachment process. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
abonie
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the advice of @sharwell but basically the idea is to assure that we have the file opened in VS prior to setting any text there.
The implementation is borrowed from Razor.