.fantomasignore - files in src/Compiler that had issues around conditional defines #14961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psfinaki
approved these changes
Mar 24, 2023
T-Gro
commented
Apr 3, 2023
T-Gro
commented
Apr 3, 2023
Member
Author
|
/run fantomas |
Co-authored-by: T-Gro <[email protected]>
Contributor
0101
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those files suffered from fsprojects/fantomas#2733 , which was addressed.
(e.g. this is what it used to produce: 49443a6 ).
Result:
--checkcommand still reports them.- I formatted them, and then put them back into ignore rule
#if !NO_TYPEPROVIDERS, because we are not yet on the version of Fantomas which fixes it.- I formatted the file, resolved the issue around the conditional directive myself, and placed it back in the ignore list.
Follow up:
With the next version of Fantomas released, we can retry and check which fixes allow us to remove more files from the ignore file.