Skip to content

Fix missing reference #14892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Fix missing reference #14892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26e0306
Fix missing reference
0101 Mar 14, 2023
0a74356
Merge remote-tracking branch 'upstream/main' into fix-missing-reference
0101 Mar 14, 2023
e615183
undo whitespace change
0101 Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/Compiler/Service/IncrementalBuild.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,11 +1058,17 @@ module IncrementalBuilderStateHelpers =
let rec createFinalizeBoundModelGraphNode (initialState: IncrementalBuilderInitialState) (boundModels: ImmutableArray<GraphNode<BoundModel>>.Builder) =
GraphNode(node {
use _ = Activity.start "GetCheckResultsAndImplementationsForProject" [|Activity.Tags.project, initialState.outfile|]
// Compute last bound model then get all the evaluated models.

// Compute last bound model then get all the evaluated models*.
let! _ = boundModels[boundModels.Count - 1].GetOrComputeValue()
let boundModels =
boundModels.ToImmutable()
|> ImmutableArray.map (fun x -> x.TryPeekValue().Value)
let! boundModels =
boundModels
|> Seq.map (fun x ->
match x.TryPeekValue() with
| ValueSome v -> node.Return v
// *Evaluating the last bound model doesn't always guarantee that all the other bound models are evaluated.
| _ -> node.ReturnFrom(x.GetOrComputeValue()))
|> NodeCode.Sequential

let! result =
FinalizeTypeCheckTask
Expand All @@ -1071,7 +1077,7 @@ module IncrementalBuilderStateHelpers =
initialState.enablePartialTypeChecking
initialState.assemblyName
initialState.outfile
boundModels
(boundModels.ToImmutableArray())
let result = (result, DateTime.UtcNow)
return result
})
Expand Down
2 changes: 1 addition & 1 deletion vsintegration/src/FSharp.Editor/Common/RoslynHelpers.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ module internal RoslynHelpers =
| :? OperationCanceledException ->
tcs.TrySetCanceled(cancellationToken) |> ignore
| exn ->
System.Diagnostics.Trace.WriteLine("Visual F# Tools: exception swallowed and not passed to Roslyn: {0}", exn.Message)
System.Diagnostics.Trace.TraceError("Visual F# Tools: exception swallowed and not passed to Roslyn: {0}", exn)
let res = Unchecked.defaultof<_>
tcs.TrySetResult(res) |> ignore
),
Expand Down