Skip to content

Conversation

@psfinaki
Copy link
Contributor

@psfinaki psfinaki commented Mar 1, 2023

Shamelessly stealing this from Razor - credits go to @ryanbrandenburg.

image

@psfinaki psfinaki requested a review from a team as a code owner March 1, 2023 17:22
@psfinaki psfinaki enabled auto-merge (squash) March 1, 2023 17:49
@T-Gro
Copy link
Member

T-Gro commented Mar 2, 2023

Can we please do it outside of the slowest jobs?
Semantically, makes most sense to have it just in "testVs".

Ideally if it can be at least avoided for "testDesktop", because that is the slowest job of them all.

@psfinaki
Copy link
Contributor Author

psfinaki commented Mar 2, 2023

Can we please do it outside of the slowest jobs?

It's really just 5 seconds - see the screenshot :) IMO not worth complicating the pipeline logic. We can split it later if we have more auxiliary steps like this.

@psfinaki psfinaki merged commit caa49fe into dotnet:main Mar 2, 2023
@T-Gro
Copy link
Member

T-Gro commented Mar 2, 2023

So we need it 4 times or don't?
I don't think things would be more complicated if this would run e.g. automatically together with the testVs option (handled within the build script, where it already has its own code block in the powershell script).

@psfinaki psfinaki deleted the vs-info branch March 2, 2023 12:00
@psfinaki
Copy link
Contributor Author

psfinaki commented Mar 2, 2023

Alright, I'll move things around a bit next time I'm here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants