Skip to content

Unit test FSharpNavigateToSearchService #14824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

Unit test FSharpNavigateToSearchService #14824

merged 2 commits into from
Feb 28, 2023

Conversation

@majocha
Copy link
Contributor

@majocha majocha commented Feb 28, 2023

@psfinaki I added a few unit tests to unblock #14746.

I skipped some to mark bugs/limitations of current NavigateToSearchService implementation.

@majocha majocha requested a review from a team as a code owner February 28, 2023 08:49
@majocha
Copy link
Contributor Author

majocha commented Feb 28, 2023

@dotnet-policy-service agree

0101
0101 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@0101 0101 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised the camel case works, didn't think it did. In practice the results are so badly ordered it looks like it doesn't work. We should definitely improve it.

(edit: created an issue for it: #14826 )

@0101 0101 merged commit 6937d77 into dotnet:main Feb 28, 2023
@majocha majocha deleted the navigate-to-search-tests branch March 1, 2023 07:48
@psfinaki
Copy link
Contributor

psfinaki commented Mar 1, 2023

@majocha thanks for adding a few turtles to the codebase, I love turtles :D

@allisonchou allisonchou mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@majocha @psfinaki @0101 @T-Gro @vzarytovskii