Skip to content

Nested Record Field Copy and Update #14821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Mar 20, 2023
Merged

Nested Record Field Copy and Update #14821

merged 41 commits into from
Mar 20, 2023

Conversation

@kerams
Copy link
Contributor

@kerams kerams commented Feb 27, 2023 •
edited
Loading

Bringing #4511 back from the dead.

This necromantic work includes proper Intellisense and anonymous record support.

devenv_PJVg1QrV7u

@kerams kerams requested a review from a team as a code owner February 27, 2023 19:24
kerams
kerams commented Feb 27, 2023
View reviewed changes
@vzarytovskii
Copy link
Member

vzarytovskii commented Feb 27, 2023 •
edited
Loading

@kerams I think the original pr links to a rejected suggestion, however, I believe this implementation is something which was approved, right? I can't find it in suggestions repo though, but I'm sure I've seen it.

@kerams
Copy link
Contributor Author

kerams commented Feb 27, 2023

From my understanding the suggestion was too broad, while the PR has a much more focused RFC. Don did have a couple of remarks in the comments, but otherwise he seemed to be favorable.

@T-Gro
Copy link
Member

T-Gro commented Feb 27, 2023

The closest I found is this RFC in the archived folder:
https://github.com/fsharp/fslang-design/blob/957d2ccd7667ab94b1ffc9ebf329fd3d822653a1/archived/FS-1049-nested-record-field--copy-and-update-expression.md

Would be good to read what @dsyme says about resurrecting it just in this limited form (like in the screenshot in this PR's description).

kerams
kerams commented Feb 27, 2023
View reviewed changes
@kerams
Copy link
Contributor Author

kerams commented Feb 27, 2023

fsharp/fslang-design#733 created for a design discussion.

@dsyme
Copy link
Contributor

dsyme commented Mar 1, 2023

I do like this feature and will mark the limited version of it approved in principle, leaving some additional comments

vzarytovskii
vzarytovskii reviewed Mar 13, 2023
View reviewed changes
vzarytovskii
vzarytovskii reviewed Mar 13, 2023
View reviewed changes
@vzarytovskii
Copy link
Member

vzarytovskii commented Mar 13, 2023

Just a few minor comments.

dsyme
dsyme reviewed Mar 15, 2023
View reviewed changes
@kerams kerams requested a review from dsyme March 15, 2023 18:38
@T-Gro
Copy link
Member

T-Gro commented Mar 20, 2023

The test case with dotted field has been added, can we merge here?

@vzarytovskii vzarytovskii enabled auto-merge (squash) March 20, 2023 15:43
@vzarytovskii vzarytovskii merged commit a6563cd into dotnet:main Mar 20, 2023
@kerams kerams deleted the nest branch March 20, 2023 15:45
@vzarytovskii vzarytovskii mentioned this pull request Jun 10, 2023
Closed
@auduchinok auduchinok mentioned this pull request Jul 12, 2023
Merged
@DedSec256 DedSec256 mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro approved these changes

@dsyme dsyme Awaiting requested review from dsyme

+2 more reviewers

@auduchinok auduchinok auduchinok left review comments

@brianrourkeboll brianrourkeboll brianrourkeboll left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kerams @vzarytovskii @T-Gro @dsyme @auduchinok @brianrourkeboll