Simplify checking format strings #14804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
force-pushed
the
simplify_check_format_strings
branch
3 times, most recently
from
2e8eadf to
46b040a
Compare
psfinaki
reviewed
Feb 27, 2023
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Are there already tests for this?
Member
Author
Good question. There are various tests related to this, but I am not 100% confident that their coverage is good enough. I'll check it out, although atm struggling with building fsharp locally |
Seems like checking for end line flex and whether string is interpolated is not necessary for splitting format string into fragments, although I am not entirely sure about either of those.
abonie
force-pushed
the
simplify_check_format_strings
branch
from
28d1874 to
67919b1
Compare
0101
approved these changes
Feb 27, 2023
Contributor
0101
left a comment
0101
left a comment
There was a problem hiding this comment.
I definitely like the simplification. Would be nice to see about the tests though. Maybe try putting some errors there and see if any tests fail? If not we probably need to add some.
T-Gro
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like checking for end line flex and whether string is interpolated is not necessary for splitting format string into fragments, although I am not entirely sure about either of those.