Add test flag to dump signature data. #14790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Feb 23, 2023
psfinaki
approved these changes
Feb 23, 2023
Contributor
There was a problem hiding this comment.
I like the wording "less temporary" :)
One suggestion is to split the new code in TypedTreeOps somewhere. It breaks my heart to see the file that big and getting even bigger. But if you don't have an idea about how to easily do that - that's okay.
Edit: oh it got auto-merged 🤷
Member
|
Splitting big files should just be a separate churn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add a (temporary or less temporary) test flag
--test:DumpSignatureDatathat converts themspecto json afterApplyExportRemappingToEntity.This is to help in the investigation of #14734.
I was able to see that
ReportWarningscan have a difference arg names when compiling multiple times using--graphmode.Some samples.zip.
It is also interesting to compare
graphversusnon-graph.If you are on board with having this test flag,
visitEntityandvisitValprobably could use improvements as I'm not quite sure what information I'm exactly after.