Extending some Fantomas CI #14782
Merged
Extending some Fantomas CI #14782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
approved these changes
Feb 22, 2023
nojaf
approved these changes
Feb 22, 2023
3 tasks
0101
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14667.
The reason is pretty much explained by @nojaf in that ticket. I unignored Editor tests in the config but not in the CI - hence with time the code deviated from the Fantomas conventions.
I think this should be sufficient. We should apply Fantomas to the root and have things ignored in one place - in the config.
To be sure I also ran the script in the ticket against this branch - no changes detected.