Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Feb 21, 2023

In light of fsprojects/FSharp.Formatting#794, I want to update all documentation links from https://docs.microsoft.com/ to https://learn.microsoft.com/.

@nojaf nojaf requested a review from a team as a code owner February 21, 2023 07:13
@baronfel
Copy link
Member

Can you please also scrub 'en-us' from all docs links that are updated in this PR?

Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, however, per @baronfels request.
I believe if you remove the en-us from the urls, then it will go to localized versions of the documention depending on the browsers configuration.

E.g:
https://learn.microsoft.com/azure/devops/pipelines/yaml-schema?view=vsts&tabs=schema#job

On my browser goes to: https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=vsts&tabs=schema#job

So it would probably be preferable if we didn't make everyone read the us version of the docs.

Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Kevin

@KevinRansom KevinRansom enabled auto-merge (squash) February 22, 2023 07:22
@KevinRansom KevinRansom merged commit 52bfa8c into dotnet:main Feb 22, 2023
@nojaf nojaf deleted the fix-links branch February 22, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants