Skip to content

Conversation

@T-Gro
Copy link
Member

@T-Gro T-Gro commented Feb 15, 2023

1.Reverts #14742 which moves out-of-proc Fsharp.Suite tests (Win only) to Componenent tests (all OSes).

  • This gives us way better coverage for Linux and MacOs
  • There is a visible reduction in CI runtimes for the 2 slowest jobs:
    • example BEFORE:
      image
    • example AFTER:
      image
      ====> This means 29 minutes off the slowest job
  1. Make the tests non-flaky
    • The issue was in multi-emit FSI (MethodNotFound on a boundary between FSI_001 called from FSI_002)
    • Approach this by checking why it fails, and by doing a single pass script execution
  2. Incorporate changes needed for the tests which are currently ignored (failing in the old Fsharp.Suite)

BONUS, learned while implementing:

  1. Allow non-inline literals to be used as printf format #14670 introduced a regression which failed all implicit conversions from literal strings (e.g. to XNamespace or to XName). Enablement of the tests showed it
  2. This behavior is now fixed here, the handling of constant strings depends on being format/not format and inline/static field => 4 cases
  3. Probably since (a hypothesis only!) this change in MacOs 11 VM actions/runner-images@bf50e0d , a specific test using #r nuget: on MacOS started to fail. Disabling this test on MacOs for now, will troubleshoot on MacOs separately

@T-Gro T-Gro marked this pull request as ready for review February 17, 2023 19:41
@T-Gro T-Gro requested a review from a team as a code owner February 17, 2023 19:41
@T-Gro T-Gro linked an issue Feb 17, 2023 that may be closed by this pull request
@T-Gro T-Gro changed the title Revive previously reverted "FsharpSuite.tests reduction diet" Revive "FsharpSuite.tests reduction diet" => saves 29 minutes off slowest CI job Feb 17, 2023
@T-Gro T-Gro requested a review from kerams February 17, 2023 20:17
@abonie abonie merged commit cd2babe into main Feb 21, 2023
@T-Gro T-Gro deleted the revert-14742-revert-14590-fsharp-suite-reduction-diet branch February 27, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Speed up slowest CI job - the one running FsharpSuite.Tests

7 participants