Remove unused values from compilation to avoid FS1182 #14750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is needed for 8.0 Preview 1 release. Needs to be merged ASAP. |
Contributor
Member
|
It's either this or remove defining of no_typeproviders in props file. |
vzarytovskii
approved these changes
Feb 14, 2023
Member
I can just merge it without waiting on CI, if you've checked it locally or in source build. |
mthalman
added a commit
to mthalman/installer
that referenced
this pull request
Feb 14, 2023
This is replaced by the repo fix: dotnet/fsharp#14750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix build errors when attempting to source-build fsharp with the bootstrap flow, using the latest 8.0 preview 1 SDK as the target SDK to build the project. This results in FS1182 warnings for several cases of unused values, which are then treated as errors.
These changes address the issue by compiling out the values for the condition that they're not referenced.