Skip to content

Conversation

@kerams
Copy link
Contributor

@kerams kerams commented Feb 11, 2023

Before:

image

After:

image

@kerams kerams requested a review from a team as a code owner February 11, 2023 19:21
Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully I am just not getting it - can you please explain to me why we do not need to check the feature (even recursively within subexpressions) for AttribBitwiseOrExpr ?

Based on my understand, an expression like this (? pls correct me?):
attribProp = 15 ||| (15*16*17)

@kerams kerams requested a review from T-Gro February 21, 2023 09:36
@vzarytovskii vzarytovskii merged commit dec4bef into dotnet:main Mar 3, 2023
@kerams kerams deleted the lit branch March 3, 2023 13:14
@vzarytovskii
Copy link
Member

vzarytovskii commented Mar 3, 2023

Wanted make a comment on

the world does not end if someone manages to make use of this in 7.0.

Certainly not the end of the world, and it's fine for this change or when it's bugfix, however, when possible, we should keep features under language version, so every language version had a specific set of things, and is deterministic in terms of codegen and behaviour.

It helps to avoid confusions like certain feature supported in language version X on net8, but not supported in same version on net7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants