-
Notifications
You must be signed in to change notification settings - Fork 830
Improve diagnostics for ArithmeticInLiterals #14735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
T-Gro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully I am just not getting it - can you please explain to me why we do not need to check the feature (even recursively within subexpressions) for AttribBitwiseOrExpr ?
Based on my understand, an expression like this (? pls correct me?):
attribProp = 15 ||| (15*16*17)
|
Wanted make a comment on
Certainly not the end of the world, and it's fine for this change or when it's bugfix, however, when possible, we should keep features under language version, so every language version had a specific set of things, and is deterministic in terms of codegen and behaviour. It helps to avoid confusions like certain feature supported in language version X on net8, but not supported in same version on net7 |
Before:
After: