Skip to content

Generate IsReadOnlyAttribute on unsupported platforms. #14724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 22, 2023
Merged

Generate IsReadOnlyAttribute on unsupported platforms. #14724

merged 13 commits into from
Feb 22, 2023

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Feb 10, 2023 •
edited
Loading

We recently encountered issues with IsReadOnlyAttribute on unsupported platforms

This PR, will generate one when the targeted platform does not support IsReadOnlyAttribute ... particularly netstandard2.0

Todo:

  • Clean up the code a bit and do a better job of abstracting out the generated types, because there are other attributes that are based on name matching rather than types.
  • Add some tests, I have an Okay idea how to test this, so I will add a test or two.
  • Attach CompilerGeneratedAttribute, EditorBrowsableAttribute(EditorBrowsableState.Never), DebuggerNonUserCodeAttribute to locally generated System Attribute (I.e. IsReadOnlyAttribute )

Right now I just want to see what tests are broken by this change.

@KevinRansom KevinRansom requested a review from a team as a code owner February 10, 2023 02:51
TIHan
TIHan reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me so far

vzarytovskii
vzarytovskii reviewed Feb 10, 2023
View reviewed changes
@KevinRansom KevinRansom force-pushed the readonlyattribute branch 2 times, most recently from a04d842 to 60af412 Compare February 10, 2023 22:44
T-Gro
T-Gro reviewed Feb 10, 2023
View reviewed changes
@vzarytovskii
Copy link
Member

vzarytovskii commented Feb 11, 2023

Does this play well with parallel ilxgen? I presume yes, but just wanted to make sure.
Introduced in #14372

@KevinRansom
Copy link
Contributor Author

KevinRansom commented Feb 11, 2023

Does this play well with parallel ilxgen? I presume yes, but just wanted to make sure. Introduced in #14372

I would expect so. The embedded typedefs are accumulated in a concurrent collection.

T-Gro
T-Gro reviewed Feb 13, 2023
View reviewed changes
@KevinRansom KevinRansom reopened this Feb 14, 2023
vzarytovskii
vzarytovskii reviewed Feb 20, 2023
View reviewed changes
@KevinRansom KevinRansom enabled auto-merge (squash) February 22, 2023 09:59
@KevinRansom KevinRansom merged commit 285fb61 into dotnet:main Feb 22, 2023
@allisonchou allisonchou mentioned this pull request Feb 23, 2023
Closed
@KevinRansom KevinRansom deleted the readonlyattribute branch April 29, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro left review comments

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@abonie abonie abonie approved these changes

+1 more reviewer

@TIHan TIHan TIHan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KevinRansom @vzarytovskii @TIHan @abonie @T-Gro