Skip to content

Clean up NameResolution.fs #14722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2023
Merged

Clean up NameResolution.fs #14722

merged 2 commits into from
Feb 10, 2023

Conversation

@kerams
Copy link
Contributor

@kerams kerams commented Feb 9, 2023

Factoring out some common bits.

@kerams kerams requested a review from a team as a code owner February 9, 2023 10:54
kerams
kerams commented Feb 9, 2023
View reviewed changes
psfinaki
psfinaki approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kerams. Keep rocking :)

@T-Gro T-Gro merged commit 337d0af into dotnet:main Feb 10, 2023
@kerams kerams deleted the clean branch February 10, 2023 22:24
@allisonchou allisonchou mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro approved these changes

+2 more reviewers

@forki forki forki left review comments

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kerams @forki @vzarytovskii @psfinaki @T-Gro