Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Feb 8, 2023

The struct keyword should be included in the range of:

struct {| X = 9; X = 10 |}
struct (9, 10)

This was the case for tuples but not for anonymous records.
In this PR is correct this for anon records.

@nojaf nojaf requested a review from a team as a code owner February 8, 2023 10:42
@psfinaki psfinaki enabled auto-merge (squash) February 8, 2023 11:20
@psfinaki psfinaki merged commit fd391a0 into dotnet:main Feb 8, 2023
@nojaf
Copy link
Contributor Author

nojaf commented Feb 8, 2023

This is most likely my fastest merged PR and I cannot express how happy this makes me!
Thanks everyone!

@psfinaki
Copy link
Contributor

psfinaki commented Feb 8, 2023

You are doing awesome job @nojaf, keep rocking :)

@nojaf nojaf deleted the fix-struct-anon-record-range branch February 8, 2023 12:59
@nojaf nojaf mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants