Include settable properties in attribute completions #14697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerams
commented
Feb 5, 2023
kerams
commented
Feb 5, 2023
Contributor
Author
|
Ok, so the Migrated it from the legacy test suite, so it should hopefully be fine now. |
Contributor
Since it was under legacy language service I'd say it's ok. |
0101
approved these changes
Feb 6, 2023
abonie
approved these changes
Feb 9, 2023
T-Gro
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14696.
I've introduced
SyntaxVisitorBase.VisitAttributeApplicationto make attribute application traversal more uniform.