Skip to content

Conversation

@kerams
Copy link
Contributor

@kerams kerams commented Feb 3, 2023

@kerams kerams requested a review from a team as a code owner February 3, 2023 17:02
@T-Gro
Copy link
Member

T-Gro commented Feb 6, 2023

Do I understand it correctly that this implements a part of what #14132 tries to do as well?
So #14132 will either take over this implementation, or replace it with what it has (in a more generic way).. ?

@vzarytovskii
Copy link
Member

vzarytovskii commented Feb 6, 2023

Do I understand it correctly that this implements a part of what #14132 tries to do as well? So #14132 will either take over this implementation, or replace it with what it has (in a more generic way).. ?

They cover different cases, this one is strictly about static members in interfaces, the other one is about static members and bindings in unions and types without incremental contstructor.

@kerams kerams requested a review from T-Gro February 6, 2023 14:15
@kerams
Copy link
Contributor Author

kerams commented Feb 8, 2023

I've revamped error messages a little. Message 868 is changed so that it explicitly mentions concrete instance members, and the new diagnostic is removed completely. In the case of concrete static members and a failing feature check, Feature 'Static members in interfaces' is not available in F# 7.0. Please use language version 'PREVIEW' or greater. is given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants