-
Notifications
You must be signed in to change notification settings - Fork 830
Integration tests for F# #14690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests for F# #14690
Conversation
|
This is from the CI run on this PR: Passed! - Failed: 0, Passed: 7, Skipped: 0, Total: 7, Duration: 7 m 17 s - FSharp.Editor.IntegrationTests.dll (net472) I don't think this is a good idea to have. |
T-Gro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed! - Failed: 0, Passed: 7, Skipped: 0, Total: 7, Duration: 7 m 17 s - FSharp.Editor.IntegrationTests.dll (net472)
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@T-Gro everything is an "added reason for failing CI". If these proves to be consistently passing, this shouldn't be an obstacle in that sense. Extra time is a different thing. A few minutes is probably something we can live with but yeah that's not scalable. I will look into what other repos do about integration tests in CI, we should basically follow. @shamwell any advice? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…aki/fsharp into psfinaki/integration-tests
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Addressed most, let's run it in CI for a while and see if it's stable enough for us.
The tests for now are in C#. That's because:
Tests run in a separate CI leg:
