Skip to content

Conversation

@vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Jan 23, 2023

Fixes #14053, more info in dotnet/roslyn#50391, IFSharpFindDefinitionService will be replacing IFSharpGoToDefinitionService

@CyrusNajmabadi @333fred do we need to do anything else? When I remove the FSharpGoToDefinitionService, FSharpFindDefinitionService isn't getting called now in VS debug when I try to navigate to definition.

@vzarytovskii vzarytovskii requested a review from a team as a code owner January 23, 2023 15:18
@333fred
Copy link
Member

333fred commented Jan 24, 2023

I wouldn't expect you to need to do anything else. It should be getting pulled in at https://github.com/dotnet/roslyn/blob/main/src/EditorFeatures/Core/GoToDefinition/GoToDefinitionHelpers.cs#L142.

@vzarytovskii
Copy link
Member Author

vzarytovskii commented Jan 24, 2023

I wouldn't expect you to need to do anything else. It should be getting pulled in at https://github.com/dotnet/roslyn/blob/main/src/EditorFeatures/Core/GoToDefinition/GoToDefinitionHelpers.cs#L142.

@333fred yeah, that's what I expected too, but when I'm remove the exports from the old service, breakpoints are not getting hit in the new service.

@333fred
Copy link
Member

333fred commented Jan 24, 2023

Have you tried setting breakpoints in the Roslyn locations and seeing what's happening? Are there any mef composition errors?

@vzarytovskii
Copy link
Member Author

Have you tried setting breakpoints in the Roslyn locations and seeing what's happening? Are there any mef composition errors?

Haven't checked it yet, was my next step to see if it's getting imported and build and deploy roslyn part

@vzarytovskii
Copy link
Member Author

I am going to merge this one to fix the MEF export issues, otherwise it will be stale.
I will investigate why Roslyn doesn't call it separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Missing MEF export of IFSharpFindDefinitionService in VS

4 participants