Reserve an error message for "obj was inferred" #14642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psfinaki
reviewed
Jan 23, 2023
…arp-1 into obj-inference-error-message
Smaug123
commented
Jan 26, 2023
Contributor
Author
|
Now "A type has been implicitly inferred as |
Contributor
Author
|
I would like to get this in at some point in the near future, because this is the part of the change that rots the fastest. |
psfinaki
approved these changes
Jan 27, 2023
Contributor
|
I am fine with the wording now. @dotnet/fsharp-team-msft ping |
abelbraaksma
suggested changes
Jan 30, 2023
Contributor
abelbraaksma
left a comment
abelbraaksma
left a comment
There was a problem hiding this comment.
Small nitpick, see below (I didn't repeat the comment for all translation files, these are generated automatically anyway). Otherwise good.
abelbraaksma
approved these changes
Jan 31, 2023
Contributor
abelbraaksma
left a comment
abelbraaksma
left a comment
There was a problem hiding this comment.
Looking good! I think this can be merged @vzarytovskii, @dsyme, @KevinRansom
T-Gro
approved these changes
Jan 31, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is boilerplate around fsharp/fslang-suggestions#696 .
The actual implementation is #13298, but that has rotted several times. I'd like to get this boilerplate out of the way so that it stops rotting.