Skip to content

Disable two tests in ExprTests in DEBUG, non-NetFramework only - they fail due to StackOverflow exception on NetCore+DEBUG configuration.. #14637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Disable two tests in ExprTests in DEBUG, non-NetFramework only - they fail due to StackOverflow exception on NetCore+DEBUG configuration.. #14637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c26046
Disable two failing ExprTests in DEBUG mode
safesparrow Jan 20, 2023
b8d2322
Do not ignore the tests in DEBUG+NETFRAMEWORK configuration.
safesparrow Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/service/ExprTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,13 @@ let test{0}ToStringOperator (e1:{1}) = string e1

"""

let ignoreTestIfStackOverflowExpected () =
#if !NETFRAMEWORK && DEBUG
Assert.Ignore("Test is known to fail in DEBUG when not using NetFramework. Use RELEASE configuration or NetFramework to run it.")
#else
()
#endif

/// This test is run in unison with its optimized counterpart below
[<Test>]
let ``Test Unoptimized Declarations Project1`` () =
Expand Down Expand Up @@ -3191,6 +3198,7 @@ let BigSequenceExpression(outFileOpt,docFileOpt,baseAddressOpt) =

[<Test>]
let ``Test expressions of declarations stress big expressions`` () =
ignoreTestIfStackOverflowExpected ()
let cleanup, options = ProjectStressBigExpressions.createOptions()
use _holder = cleanup
let exprChecker = FSharpChecker.Create(keepAssemblyContents=true)
Expand All @@ -3207,6 +3215,7 @@ let ``Test expressions of declarations stress big expressions`` () =

[<Test>]
let ``Test expressions of optimized declarations stress big expressions`` () =
ignoreTestIfStackOverflowExpected ()
let cleanup, options = ProjectStressBigExpressions.createOptions()
use _holder = cleanup
let exprChecker = FSharpChecker.Create(keepAssemblyContents=true)
Expand Down