Sort fsharpcore baseline, and move them to baseline files #14597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
reviewed
Jan 12, 2023
T-Gro
reviewed
Jan 12, 2023
T-Gro
approved these changes
Jan 12, 2023
KevinRansom
force-pushed
the
sortBaseline
branch
from
662fd24 to
6ac44fb
Compare
T-Gro
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: #14589
Has a lot of churn in the baseline. This is because we never sorted the output file from the test, and expected developers to copy and paste deltas from the output file into the baseline. This was pretty lame.
So ...
This pr moves the baseline from fsharp source code into .bsl files. There is one for each checked combination, platform net472 and netcoreapp as well as build flavour, debug and release.
net472 actually tests the netstandard2.0 F# core, netcoreapp the netstandard2.1 FSharp.Core.
It also includes automatic updates of the baseline when the environment variable is used:
set TEST_UPDATE_BSL=1Implements this also for FSharp.Compiler.Service unit tests.
Also add checking for referenced assemblies.