Skip to content

Don't show parameter name hints when they coincide with argument names #14581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 11, 2023
Merged

Don't show parameter name hints when they coincide with argument names #14581

merged 5 commits into from
Jan 11, 2023

Conversation

@psfinaki
Copy link
Contributor

@psfinaki psfinaki commented Jan 10, 2023

closes #14447

When you have good argument and parameter names, you don't need hints.

image

@psfinaki psfinaki requested a review from a team as a code owner January 10, 2023 14:10
@psfinaki
Copy link
Contributor Author

psfinaki commented Jan 10, 2023 •
edited
Loading

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 10, 2023

Command 'rin' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 10, 2023

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Contributor Author

psfinaki commented Jan 10, 2023

/azp run

@psfinaki psfinaki enabled auto-merge (squash) January 10, 2023 18:58
@azure-pipelines
Copy link

azure-pipelines bot commented Jan 10, 2023

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Contributor Author

psfinaki commented Jan 11, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 11, 2023

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki requested a review from vzarytovskii January 11, 2023 12:37
0101
0101 reviewed Jan 11, 2023
View reviewed changes
@psfinaki
Copy link
Contributor Author

psfinaki commented Jan 11, 2023

@vzarytovskii @0101 CI is green, please approve/reapprove

@psfinaki psfinaki merged commit f7a1fd8 into dotnet:main Jan 11, 2023
@psfinaki psfinaki deleted the psfinaki/hints-10 branch January 11, 2023 16:39
@allisonchou allisonchou mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't show parameter name hints when they coincide with argument names

3 participants

@psfinaki @0101 @vzarytovskii