Warn if unused top-level function is not included is signature file. #14567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
changed the title
auduchinok
reviewed
Jan 9, 2023
nojaf
force-pushed
the
unused-function-signature-file
branch
from
ef10779 to
34f45a8
Compare
Merged
T-Gro
reviewed
Jan 11, 2023
auduchinok
reviewed
Jan 11, 2023
nojaf
force-pushed
the
unused-function-signature-file
branch
from
5ec4a7d to
6e3aa92
Compare
Contributor
Author
|
Ready for review |
abonie
approved these changes
Jan 17, 2023
tests/FSharp.Compiler.ComponentTests/CompilerOptions/fsc/warnon/warnon.fs
Show resolved
Hide resolved
edgarfgp
approved these changes
Jan 19, 2023
psfinaki
approved these changes
Jan 19, 2023
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Good stuff. It's like - "we should have had this 10 years ago". Thanks :)
auduchinok
reviewed
Jan 19, 2023
vzarytovskii
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I would like to warn the user when a public function in an implementation file is not used and is not part of the signature file.
The implementation could improve, but I think the idea holds.
Let me know how I can properly check for this.