Fix net452 template #14561
Merged
Fix net452 template #14561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
approved these changes
Jan 9, 2023
psfinaki
approved these changes
Jan 9, 2023
KevinRansom
suggested changes
Jan 9, 2023
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
We should remove all framework types lower than net48, and add I believe add one for net 4.8.1.
We do no testing for anything lower than 4.8 anyway, and these are for creating new projects. If a developer believes their project runs on a lower dotnet framework they can manually edit the project.
KevinRansom
approved these changes
Jan 13, 2023
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Oh they are controlled by vs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/75040821/how-to-create-f-console-application-targeting-net-framework-4-5-2-in-visual-s