Do not show type hints for optional parameters with manual type annotations #14520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
approved these changes
Jan 2, 2023
vzarytovskii
approved these changes
Jan 2, 2023
Contributor
|
@rosskuehl thanks a lot for your contributions to the hints and for refactoring the code on the way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another piece of fsharp/issues/14459
Inline type hints are still being shown for optional parameters, even when an explicit annotation is provided by the user:
Fixed:
Root cause:
IsTypeAnnotationGivenAtPositionreturns false when given the starting position of an optional parameter immediately following the?symbolSolution:
Account for
?and adjust column start by 1 for this check when detecting an optional parameter declarationComments:
This brings up another potential issue when manual annotations are subsequently removed; the parameter type is not resolved based on the usage below (see screenshot)